New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(1.20): update to golang 1.20 and IBM sarama #25

Closed

ecoupal-believe wants to merge 1 commit into electric-saw:main from ecoupal-believe:feature/fix-sasl

ecoupal-believe commented Apr 9, 2024

I needed to add tls for sasl with my msk cluster. I also updated versions.


          feat(1.20): update to golang 1.20 and IBM sarama

9caca4b

snakeice reviewed

View reviewed changes

internal/pkg/kafka/connection.go

               		case "sha512":
               			clientConfig.Net.SASL.SCRAMClientGeneratorFunc = func() sarama.SCRAMClient { return &XDGSCRAMClient{HashGeneratorFcn: SHA512} }
               			clientConfig.Net.SASL.Mechanism = sarama.SASLTypeSCRAMSHA512
+              			clientConfig.Net.TLS.Enable = true

Member

snakeice Apr 9, 2024

maybe moving into if k.Context.UseTLS { makes more sense?

snakeice closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet